Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template to include issue closing functionality #330

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

samadpls
Copy link
Contributor

@samadpls samadpls commented Sep 6, 2024

Fixes #329

Review Checklist
I certify that I have:

@JTonda JTonda requested a review from awharn September 11, 2024 15:07
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
samadpls and others added 2 commits September 11, 2024 20:14
@t1m0thyj t1m0thyj self-requested a review September 16, 2024 15:07
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (c8bdbda) to head (1214709).
Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          65       65           
  Lines        3244     3244           
=======================================
  Hits         2889     2889           
  Misses        355      355           
Flag Coverage Δ
unittests 89.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @samadpls!

@t1m0thyj t1m0thyj merged commit b00a4c1 into zowe:main Sep 16, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Add Issue Linking Section to PR Template
3 participants