Fix audit workflow and revert Secrets SDK version #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 65 65
Lines 3244 3244
=======================================
Hits 2889 2889
Misses 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Timothy Johnson <[email protected]>
zFernand0
approved these changes
Aug 27, 2024
Comment on lines
+53
to
+55
| # - name: Update version (cargo) | ||
| # run: cargo install cargo-edit && cargo set-version ${{ steps.update-version.outputs.version }} | ||
| # working-directory: src/secrets |
There was a problem hiding this comment.
Thanks for preventing the unnecessary version bumps here...
going forward, we should be able to rely on the cargo.toml version in order to specify the constrains in the core-sdk 😋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
pytestdev dep for technical currencyHow to Test
Review Checklist
I certify that I have:
Additional Comments