Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header #318

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Add license header #318

merged 9 commits into from
Jul 24, 2024

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jul 18, 2024

What It Does
Adds license header for files and updates workflow with auto check and addition for license headers. [#293]

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (307ec04) to head (43511a5).
Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files          53       53           
  Lines        2813     2813           
=======================================
  Hits         2529     2529           
  Misses        284      284           
Flag Coverage Δ
unittests 89.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 marked this pull request as ready for review July 18, 2024 18:50
@pem70 pem70 requested review from t1m0thyj, zFernand0 and traeok July 18, 2024 18:50
@pem70 pem70 changed the base branch from main to function_case July 19, 2024 14:19
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks @pem70! Left a few comments

src/zosmf/zowe/zosmf_for_zowe_sdk/zosmf.py Outdated Show resolved Hide resolved
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the missing licenses and for adding the script @pem70!
I left a couple comments; one is regarding the script and the other is about a duplicate license header.

src/zosmf/zowe/zosmf_for_zowe_sdk/zosmf.py Outdated Show resolved Hide resolved
.github/workflows/sdk-build.yml Outdated Show resolved Hide resolved
Base automatically changed from function_case to main July 23, 2024 18:59
@zFernand0 zFernand0 requested review from traeok and t1m0thyj July 24, 2024 12:28
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70!

It might be helpful to print the failing files even when the script isn't in "write mode," so that you can see which files have failed the check in the CI output. That said, not requesting changes for this - just a suggestion 😋

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70!

@zFernand0 zFernand0 merged commit 45c2f21 into main Jul 24, 2024
33 checks passed
@zFernand0 zFernand0 deleted the license_header branch July 24, 2024 14:13
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

  • pypi: zowe-python-sdk-bundle-1.0.0.dev19
  • pypi: zowe_core_for_zowe_sdk-1.0.0.dev19
  • pypi: zowe_zos_console_for_zowe_sdk-1.0.0.dev19
  • pypi: zowe_zos_files_for_zowe_sdk-1.0.0.dev19
  • pypi: zowe_zos_jobs_for_zowe_sdk-1.0.0.dev19
  • pypi: zowe_zos_tso_for_zowe_sdk-1.0.0.dev19
  • pypi: zowe_zosmf_for_zowe_sdk-1.0.0.dev19

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants