-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license header #318
Add license header #318
Conversation
Signed-off-by: pem70 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage 89.90% 89.90%
=======================================
Files 53 53
Lines 2813 2813
=======================================
Hits 2529 2529
Misses 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @pem70! Left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the missing licenses and for adding the script @pem70!
I left a couple comments; one is regarding the script and the other is about a duplicate license header.
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70!
It might be helpful to print the failing files even when the script isn't in "write mode," so that you can see which files have failed the check in the CI output. That said, not requesting changes for this - just a suggestion 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70!
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Adds license header for files and updates workflow with auto check and addition for license headers. [#293]
How to Test
Review Checklist
I certify that I have:
Additional Comments