Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize function names #300

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Standardize function names #300

merged 5 commits into from
Jul 1, 2024

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jun 28, 2024

What It Does
Standardizes function names that datasets to be data_sets, sets unnecessary public variables to private. Addresses [#83]

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 85.25641% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (ecf386c) to head (dd86da8).
Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
src/core/zowe/core_for_zowe_sdk/zosmf_profile.py 14.28% 6 Missing ⚠️
src/core/zowe/core_for_zowe_sdk/profile_manager.py 79.16% 5 Missing ⚠️
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 28.57% 5 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py 62.50% 3 Missing ⚠️
src/core/zowe/core_for_zowe_sdk/request_handler.py 95.45% 1 Missing ⚠️
...s_files/zowe/zos_files_for_zowe_sdk/file_system.py 83.33% 1 Missing ⚠️
src/zos_tso/zowe/zos_tso_for_zowe_sdk/tso.py 75.00% 1 Missing ⚠️
src/zosmf/zowe/zosmf_for_zowe_sdk/zosmf.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   89.72%   89.71%   -0.02%     
==========================================
  Files          53       53              
  Lines        2677     2674       -3     
==========================================
- Hits         2402     2399       -3     
  Misses        275      275              
Flag Coverage Δ
unittests 89.71% <85.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 requested review from t1m0thyj, traeok and zFernand0 June 28, 2024 15:09
@pem70 pem70 marked this pull request as ready for review June 28, 2024 15:09
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70 for standardizing these 🙂

src/core/zowe/core_for_zowe_sdk/sdk_api.py Show resolved Hide resolved
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

CHANGELOG.md Outdated Show resolved Hide resolved
tests/unit/core/test_sdk_api.py Show resolved Hide resolved
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Peizhao Mei <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70!

@zFernand0 zFernand0 merged commit 91d87ee into main Jul 1, 2024
21 checks passed
@zFernand0 zFernand0 deleted the Standardize-function-names branch July 1, 2024 15:32
@zFernand0 zFernand0 linked an issue Jul 1, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 1, 2024

Release failed for the main branch. 😢

Error: The process '/opt/hostedtoolcache/Python/3.10.14/x64/bin/twine' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/pypi.js:5314:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/pypi.js:5300:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/pypi.js:5203:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

github-actions bot commented Jul 1, 2024

Release succeeded for the main branch. 🎉

The following packages have been published:

  • pypi: zowe-python-sdk-bundle-1.0.0.dev16
  • pypi: zowe_core_for_zowe_sdk-1.0.0.dev16
  • pypi: zowe_zos_console_for_zowe_sdk-1.0.0.dev16
  • pypi: zowe_zos_files_for_zowe_sdk-1.0.0.dev16
  • pypi: zowe_zos_jobs_for_zowe_sdk-1.0.0.dev16
  • pypi: zowe_zos_tso_for_zowe_sdk-1.0.0.dev16
  • pypi: zowe_zosmf_for_zowe_sdk-1.0.0.dev16

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize method names
4 participants