-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize function names #300
Conversation
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 89.72% 89.71% -0.02%
==========================================
Files 53 53
Lines 2677 2674 -3
==========================================
- Hits 2402 2399 -3
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70 for standardizing these 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Co-authored-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Peizhao Mei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70!
Release failed for the
Check the workflow run for more error details. Powered by Octorelease 🚀 |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Standardizes function names that
datasets
to bedata_sets
, sets unnecessary public variables to private. Addresses [#83]How to Test
Review Checklist
I certify that I have:
Additional Comments