Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize response #285

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Standardize response #285

merged 8 commits into from
Jun 17, 2024

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jun 11, 2024

What It Does
addresses [#266]

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (8ac7348) to head (f02124b).
Report is 191 commits behind head on main.

Files with missing lines Patch % Lines
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   89.27%   89.37%   +0.10%     
==========================================
  Files          53       53              
  Lines        2536     2542       +6     
==========================================
+ Hits         2264     2272       +8     
+ Misses        272      270       -2     
Flag Coverage Δ
unittests 89.37% <90.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 requested review from t1m0thyj, zFernand0 and traeok June 11, 2024 17:24
@pem70 pem70 marked this pull request as ready for review June 11, 2024 17:24
@zFernand0 zFernand0 linked an issue Jun 11, 2024 that may be closed by this pull request
@zFernand0 zFernand0 changed the base branch from main to TSO June 11, 2024 19:38
@zFernand0
Copy link
Member

As a test, I went ahead and changed the base of this PR, and it seemed to have cleaned up a lot of the commits 😋
Should we keep it with the TSO branch as the base, or would you prefer for this PR to be rebased back to main?

@pem70, @t1m0thyj, and @traeok, any thoughts?

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the tests! 🥳
Left one small comment on this, but changes LGTM! 😋

CHANGELOG.md Outdated Show resolved Hide resolved
@traeok
Copy link
Member

traeok commented Jun 13, 2024

...@traeok, any thoughts?

I think it makes sense to keep the base branch as TSO, if it makes it easier to get everything merged into main 😋

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Peizhao!

Base automatically changed from TSO to main June 17, 2024 14:00
@t1m0thyj t1m0thyj dismissed zFernand0’s stale review June 17, 2024 14:08

Changes were addressed

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70!

@t1m0thyj t1m0thyj merged commit ba6d6fb into main Jun 17, 2024
21 checks passed
@t1m0thyj t1m0thyj deleted the Standardize-response branch June 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore]: Standardize response output from all SDK methods
4 participants