Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize response output #284

Closed
wants to merge 17 commits into from
Closed

Standardize response output #284

wants to merge 17 commits into from

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jun 10, 2024

What It Does
Simplify request handler to return response content directly (#266)

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (cdf6265) to head (d8bd067).

Current head d8bd067 differs from pull request most recent head af80a88

Please upload reports for the commit af80a88 to get more accurate results.

Files Patch % Lines
src/core/zowe/core_for_zowe_sdk/request_handler.py 33.33% 2 Missing ⚠️
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 0.00% 2 Missing ⚠️
src/core/zowe/core_for_zowe_sdk/profile_manager.py 50.00% 1 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 0.00% 1 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          53       53           
  Lines        2519     2530   +11     
=======================================
+ Hits         2249     2259   +10     
- Misses        270      271    +1     
Flag Coverage Δ
unittests 89.28% <77.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 marked this pull request as ready for review June 10, 2024 18:41
@pem70 pem70 marked this pull request as draft June 10, 2024 19:42
@pem70 pem70 closed this Jun 11, 2024
@pem70 pem70 deleted the Standardize-response-output branch June 11, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants