Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tso issue_command #277

Merged
merged 15 commits into from
Jun 17, 2024
Merged

Tso issue_command #277

merged 15 commits into from
Jun 17, 2024

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jun 5, 2024 •
edited
Loading

What It Does
Fixes [#260]

How to Test

Review Checklist
I certify that I have:

Additional Comments

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (cdf6265) to head (f580bd6).
Report is 214 commits behind head on main.

Files with missing lines Patch % Lines
src/core/zowe/core_for_zowe_sdk/profile_manager.py 50.00% 1 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 0.00% 1 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   89.28%   89.32%   +0.04%     
==========================================
  Files          53       53              
  Lines        2519     2529      +10     
==========================================
+ Hits         2249     2259      +10     
  Misses        270      270
Flag Coverage Δ
unittests 89.32% <90.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 requested review from t1m0thyj, zFernand0 and traeok and removed request for zFernand0 June 5, 2024 14:38
@pem70
Copy link
Collaborator Author

pem70 commented Jun 5, 2024

I also merge Timothy's comments from the previous pull requests

@pem70 pem70 marked this pull request as ready for review June 5, 2024 17:25
@zFernand0 zFernand0 mentioned this pull request Jun 5, 2024
Merged
4 tasks
pem70 added 2 commits June 7, 2024 10:48
@pem70
Revert "Merge branch 'convert_windows_line_ending' into TSO"
3de32d1 
This reverts commit 2326a40, reversing
changes made to 85d84c8.

Signed-off-by: pem70 <[email protected]>
@pem70
Update uss.py
d1c72c8 
Signed-off-by: pem70 <[email protected]>
zFernand0
zFernand0 reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 😋
Left a few comments

src/core/zowe/core_for_zowe_sdk/zosmf_profile.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
zFernand0
zFernand0 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

We should probably document somewhere that this relies on the older z/OSMF TSO APIs (similar to the NodeJS SDK).

Also, IIRC, we discussed and we were ok with not doing any client-side max-retries. We also don't seem to have them on the Node.js SDK 😋

CHANGELOG.md Outdated Show resolved Hide resolved
t1m0thyj
t1m0thyj reviewed Jun 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tests/unit/files/datasets/test_delete.py Outdated Show resolved Hide resolved
src/zos_tso/zowe/zos_tso_for_zowe_sdk/tso.py Outdated Show resolved Hide resolved
@pem70
Resolved comments
f580bd6 
Signed-off-by: pem70 <[email protected]>
t1m0thyj
t1m0thyj approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70!

@t1m0thyj t1m0thyj merged commit 3a15fc1 into main Jun 17, 2024
21 checks passed
@t1m0thyj t1m0thyj deleted the TSO branch June 17, 2024 14:00
@t1m0thyj t1m0thyj linked an issue Jun 17, 2024 that may be closed by this pull request
[zos-tso] issue_command should loop and concatenate multiple responses #260
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zFernand0 zFernand0 zFernand0 approved these changes

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@traeok traeok Awaiting requested review from traeok

Assignees

@pem70 pem70

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[zos-tso] issue_command should loop and concatenate multiple responses
3 participants
@pem70 @t1m0thyj @zFernand0