Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to use Node 20 #250

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Update workflows to use Node 20 #250

merged 3 commits into from
Feb 5, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 2, 2024

What It Does

Updates workflows to use non-deprecated Node 20 versions

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8aa91ad) 83.83% compared to head (cd8830f) 83.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files          34       34           
  Lines        2116     2116           
=======================================
  Hits         1774     1774           
  Misses        342      342           
Flag Coverage Δ
unittests 83.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the artifacts in the Secrets SDK workflow 😋

@t1m0thyj t1m0thyj merged commit 09a10d1 into main Feb 5, 2024
24 checks passed
@t1m0thyj t1m0thyj deleted the update-workflows branch February 5, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants