Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets: Resolve Linux library dep. issues; add repo and README #230

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 21, 2023

What It Does

  • Resolves issues w/ Linux library dependencies
  • Adds a repo link and README to Secrets package

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a41278e) 83.16% compared to head (1c79cb0) 83.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          34       34           
  Lines        2067     2067           
=======================================
  Hits         1719     1719           
  Misses        348      348           
Flag Coverage Δ
unittests 83.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks (@t1m0thyj) for helping me understand the project.toml properties added here 😋

@t1m0thyj t1m0thyj merged commit b62f6ec into main Nov 22, 2023
50 checks passed
@t1m0thyj t1m0thyj deleted the fix/secrets-sdk-linux branch November 22, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[secrets] ManyLinux wheels require LD_LIBRARY_PATH to be defined
3 participants