Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception handling in session.py #217

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fixed exception handling in session.py #217

merged 3 commits into from
Sep 21, 2023

Conversation

samadpls
Copy link
Contributor

What It Does

Resloved #213
How to Test

Review Checklist
I certify that I have:

Additional Comments

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/core/zowe/core_for_zowe_sdk/session.py 0.00%

📢 Thoughts on this report? Let us know!.

@samadpls samadpls requested a review from t1m0thyj September 15, 2023 14:10
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samadpls Thanks for fixing this issue 🙂 Could you please update the changelog to mention the bug fix and include a link to the issue?

Signed-off-by: Abdul Samad Siddiqui <[email protected]>
Copy link

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @samadpls.

Signed-off-by: Abdul Samad Siddiqui <[email protected]>
@t1m0thyj t1m0thyj merged commit 59498a3 into main Sep 21, 2023
19 of 20 checks passed
@t1m0thyj t1m0thyj deleted the fix/exception branch September 21, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise statements in session.py do not specify an exception type derived from BaseException
3 participants