Save Profile Properties to Config File & Secure Vault Storage (#73, #72)

[samadpls]

What It Does

Resolves #73 , #72

How to Test

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[t1m0thyj]

Looks like a good start to me 👍 Left one comment

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
tests/unit/test_zowe_core.py	99.57% <100.00%> (+0.13%)	⬆️
src/core/zowe/core_for_zowe_sdk/profile_manager.py	83.90% <87.50%> (+0.81%)	⬆️
src/core/zowe/core_for_zowe_sdk/config_file.py	87.50% <84.93%> (-0.70%)	⬇️

📢 Thoughts on this report? Let us know!.

[t1m0thyj]

Left a few comments 🙂 Also please address failing tests

[t1m0thyj]

I'm having some issues when testing this PR using the following procedure:

1. Using Zowe CLI, run zowe config init --no-prompt to create a zowe.config.json template.
2. Using the Python SDK, run a test script to update a profile property:

   from zowe.core_for_zowe_sdk import ProfileManager
   pm = ProfileManager(show_warnings=False)
   pm.load(profile_type="zosmf")
   pm.set_property("profiles.zosmf.properties.port", 1443)
   pm.save()
   

3. Receive an error because "zowe.config.user.json" is missing:

Traceback (most recent call last):
  File "/Users/Timothy/Projects/zowe/zowe-client-python-sdk/test.py", line 9, in <module>
    pm.set_property("profiles.zosmf.properties.port", 1443)
  File "/Users/Timothy/Projects/zowe/zowe-client-python-sdk/src/core/zowe/core_for_zowe_sdk/profile_manager.py", line 362, in set_property
    highest_priority_layer = self.get_highest_priority_layer(json_path)
  File "/Users/Timothy/Projects/zowe/zowe-client-python-sdk/src/core/zowe/core_for_zowe_sdk/profile_manager.py", line 334, in get_highest_priority_layer
    layer.init_from_file()
  File "/Users/Timothy/Projects/zowe/zowe-client-python-sdk/src/core/zowe/core_for_zowe_sdk/config_file.py", line 119, in init_from_file
    self.autodiscover_config_dir()
  File "/Users/Timothy/Projects/zowe/zowe-client-python-sdk/src/core/zowe/core_for_zowe_sdk/config_file.py", line 234, in autodiscover_config_dir
    raise FileNotFoundError(f"Could not find the file {self.filename}")
FileNotFoundError: Could not find the file zowe.config.user.json

[traeok]

Nice work thus far @samadpls!

Regarding the error w/ a missing zowe.config.user.json:

If I provide a zowe.config.user.json in my working directory, the code continues, but it then tries to open a zowe.config.user.json in my Zowe home directory. It fails here as it cannot find the file in my .zowe folder.

However, the code looks good so far, so I think once the error handling is added for accessing zowe.config.user.json, it should work as intended 🙂

[traeok]

For the autodiscover_config_dir function, do we want to skip over zowe.config.user.json if it does not exist? It is optional, so we should avoid throwing exceptions for a missing user-level config.

[samadpls]

This could be resolved by implementing a try-except block while invoking the function.

[traeok]

Tested w/ changes and LGTM, thanks @samadpls!

[t1m0thyj]

LGTM, thanks @samadpls!