-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] fix(secrets): Reduce keychain unlock prompts on MacOS #2406
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## zowe-v2-lts #2406 +/- ##
============================================
Coverage 91.25% 91.25%
============================================
Files 638 638
Lines 19166 19166
Branches 4064 4065 +1
============================================
Hits 17490 17490
Misses 1675 1675
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the changes in .github/workflows/secrets-sdk.yml
(i.e. removal of the CFLAGS ENV-var), this is identical to the #2394 PR
LGTM! 😋
Thanks for porting! 🥳
What It Does
Ports #2394 to zowe-v2-lts branch
How to Test
Review Checklist
I certify that I have:
Additional Comments