Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(secrets): Reduce keychain unlock prompts on MacOS #2406

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jan 8, 2025

What It Does

Ports #2394 to zowe-v2-lts branch

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (dd07c9c) to head (89e422a).
Report is 10 commits behind head on zowe-v2-lts.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v2-lts    #2406   +/-   ##
============================================
  Coverage        91.25%   91.25%           
============================================
  Files              638      638           
  Lines            19166    19166           
  Branches          4064     4065    +1     
============================================
  Hits             17490    17490           
  Misses            1675     1675           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the changes in .github/workflows/secrets-sdk.yml (i.e. removal of the CFLAGS ENV-var), this is identical to the #2394 PR

LGTM! 😋
Thanks for porting! 🥳

@zFernand0 zFernand0 merged commit 8a3a8a2 into zowe-v2-lts Jan 8, 2025
54 checks passed
@zFernand0 zFernand0 deleted the fix/macos-keychain-prompts-v2 branch January 8, 2025 20:34
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants