-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy pds into new target data set enhancement #2393
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.01%
==========================================
Files 638 638
Lines 18207 18222 +15
Branches 3895 3939 +44
==========================================
+ Hits 16620 16633 +13
- Misses 1586 1587 +1
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>
📅 Suggested merge-by date: 1/20/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @pujal0909! Left a few comments
packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality and it LGTM 🙂
@pujal0909 Please add a system test for the case where target data set does not exist.
Question for @adam-wolfe and @anaxceron - should we update the help text for the zowe copy ds
command to explain that if the target data set does not exist, it will be created?
/** | ||
* Function that checks if the data set exists | ||
**/ | ||
public static async dataSetExists( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this method isn't used outside of this file, we may want to make it private for now.
dataSetName: string | ||
): Promise<boolean> { | ||
let dsnameIndex; | ||
const dataSetList = await List.dataSet(session, dataSetName, {attributes: true, start: dataSetName}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are attributes needed or if we just need names can we list without them?
|
What It Does
The enhancement creates a new PDS and copies the source members when a target PDS is inputted that does not exist. The response informs the user a new PDS has been created.
#2349
How to Test
Use the copy command with a target PDS that does not currently exist
zowe zos-files copy ds "existing-pds" "new-pds"
Review Checklist
I certify that I have:
Additional Comments