[v3] Plugin registry field

[jace-roell]

What It Does

• Resolves bug that resulted in each plugin to have identical public registries regardless of actual installation location/reference
• Resolves bug that resulted in every plugin to have the same registry as the first if multiple were installed in the same command

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

[codecov]

Codecov Report

Attention: Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (8cb0253) to head (570b713).
Report is 2 commits behind head on next.

Files	Patch %	Lines
...erative/src/plugins/cmd/install/install.handler.ts	93.84%	4 Missing ⚠️
...rc/imperative/src/plugins/cmd/list/list.handler.ts	66.66%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2189   +/-   ##
=======================================
  Coverage   91.08%   91.09%           
=======================================
  Files         632      632           
  Lines       18007    18048   +41     
  Branches     3802     3856   +54     
=======================================
+ Hits        16402    16440   +38     
- Misses       1604     1607    +3     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

left a small comment with the area where we may need to make changes in order to fix the last few tests 😋

[t1m0thyj]

Looks pretty good, thanks @jace-roell!

Left a few comments that are optional, will approve after testing the changes 🙂

[t1m0thyj]

After updating from Zowe V2 to this branch, when running zowe plugins list I see location: undefined for all pre-existing plug-ins.

Discussed with @zFernand0:

we could read the existing plugins.json file and if it has the registry property, we can print that value as location in the zowe plugins list command (with a small warning)

[zFernand0]

As Timothy mentioned, we would want to make sure that these changes are backwards compatible with V2 😋

The functionality looks great though 😋

[traeok]

Running into the same issue with registry: undefined for pre-existing plug-ins.
Aside from that functionality LGTM, will approve once addressed 😋

resolved

[traeok]

I'm no longer seeing an undefined registry for pre-existing plugins. Thanks for addressing that 👍

---

Now that I am seeing the intended behavior for pre-existing plugins, I am wondering if it would be more readable to display a single error at the bottom of the output, and add a "symbol/character" at the end of each applicable registry?

For example, this is how it looks now with a couple plugins:

Users with several Zowe plugins might be caught off guard by numerous pre-existing plugin warnings that show after upgrading to v3.

Here's how that above idea could look in the command output:

This is only a suggestion though, not requesting changes here. I think it looks ready to merge as-is 😋

LGTM, thanks @jace-roell! Will re-approve once failing integration tests are resolved

[t1m0thyj]

Several integration tests are failing in GitHub workflows. Could you revert changes to the snapshot files in this PR? I don't believe they should have changed at all, unless there are any related to zowe plugins commands.

I like the suggestion from @traeok to show a single warning at the end of output but agree it's not a required change. 😋

resolved

[traeok]

Latest changes LGTM, thanks Jace

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[t1m0thyj]

LGTM, thanks @jace-roell!

[zFernand0]

LGTM! 😋

---

[github-actions]

Release succeeded for the next branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}