-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provided requested fix to zos-jobs list --help-examples (same changes from vnext) #2093
Conversation
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2093 +/- ##
========================================
Coverage 91.06% 91.06%
========================================
Files 636 636
Lines 18992 18992
Branches 3983 3871 -112
========================================
Hits 17296 17296
Misses 1695 1695
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Not sure if we need a changelog/new-version for this help text update.
If we do not plan to release it as a new version, then we should do release-current
😋
|
I think release-current is fine, we can probably combine this fix with our next patch/minor release 😋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise!
What It Does
same fix to description as in recent vnext pr
How to Test
run
zos-jobs list --help-examples
to see string concatenation issue resolvedReview Checklist
I certify that I have: