Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provided requested fix to zos-jobs list --help-examples (same changes from vnext) #2093

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ATorrise
Copy link
Contributor

What It Does
same fix to description as in recent vnext pr

How to Test
run zos-jobs list --help-examples to see string concatenation issue resolved

Review Checklist
I certify that I have:

Signed-off-by: Amber Torrise <[email protected]>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (b166d4e) to head (c280a5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2093    +/-   ##
========================================
  Coverage   91.06%   91.06%            
========================================
  Files         636      636            
  Lines       18992    18992            
  Branches     3983     3871   -112     
========================================
  Hits        17296    17296            
  Misses       1695     1695            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Not sure if we need a changelog/new-version for this help text update.
If we do not plan to release it as a new version, then we should do release-current 😋

@ATorrise
Copy link
Contributor Author

LGTM! 😋 Not sure if we need a changelog/new-version for this help text update. If we do not plan to release it as a new version, then we should do release-current 😋

@t1m0thyj ?

@t1m0thyj
Copy link
Member

LGTM! 😋 Not sure if we need a changelog/new-version for this help text update. If we do not plan to release it as a new version, then we should do release-current 😋

@t1m0thyj ?

I think release-current is fine, we can probably combine this fix with our next patch/minor release 😋

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise!

@zFernand0 zFernand0 merged commit 82e667a into master Mar 19, 2024
20 checks passed
@zFernand0 zFernand0 deleted the fix-description branch March 19, 2024 16:31
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Mar 19, 2024
@ATorrise ATorrise restored the fix-description branch March 26, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants