-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove V1 Profile write functions #2085
Conversation
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Remove all write functions from V1ProfileConversion Replace 'team config' with 'Zowe client config' Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/imperative/src/profiles/src/utils/__tests__/V1ProfileConversion.unit.test.ts
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2085 +/- ##
==========================================
- Coverage 90.93% 90.91% -0.03%
==========================================
Files 616 616
Lines 17393 17348 -45
Branches 3586 3681 +95
==========================================
- Hits 15817 15772 -45
Misses 1575 1575
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple CodeQL warnings, will approve once addressed.
Yep. I have not gotten to the code scanning warnings yet. Will do. |
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gejohnston! 😀
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gejohnston!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no new breaking changes found in ZE.
LGTM! 😋
I should probably mention that I found a breaking change but it wasn't related to the changes in this PR. And Timothy already addressed it in the PR below:
Thank you both! 🥳
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
How to Test
Review Checklist
I certify that I have:
Additional Comments