Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V1 Profile write functions #2085

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Remove V1 Profile write functions #2085

merged 11 commits into from
Mar 14, 2024

Conversation

gejohnston
Copy link
Member

What It Does

  • Renamed ProfileIO to V1ProfileConversion
  • Removed all write functions from V1ProfileConversion #1703
  • Removed deprecated functions ConfigProfiles.expandPath and ProcessUtils.execAndCheckOutput
  • Replaced the text 'team config' with 'Zowe client config' #2019

How to Test

  • All Zowe commands continue to work as before (including convert-profiles).

Review Checklist
I certify that I have:

Additional Comments

Remove all write functions from V1ProfileConversion
Replace 'team config' with 'Zowe client config'

Signed-off-by: Gene Johnston <[email protected]>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (777a558) to head (142a3c1).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2085      +/-   ##
==========================================
- Coverage   90.93%   90.91%   -0.03%     
==========================================
  Files         616      616              
  Lines       17393    17348      -45     
  Branches     3586     3681      +95     
==========================================
- Hits        15817    15772      -45     
  Misses       1575     1575              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple CodeQL warnings, will approve once addressed.

@gejohnston
Copy link
Member Author

Yep. I have not gotten to the code scanning warnings yet. Will do.

@gejohnston gejohnston requested a review from awharn March 13, 2024 17:24
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gejohnston! 😀

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.9% Coverage on New Code (required ≥ 80%)
11.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gejohnston!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new breaking changes found in ZE.
LGTM! 😋


I should probably mention that I found a breaking change but it wasn't related to the changes in this PR. And Timothy already addressed it in the PR below:

Thank you both! 🥳

@gejohnston gejohnston merged commit 789a0a3 into next Mar 14, 2024
43 of 44 checks passed
@gejohnston gejohnston deleted the rm-v1-profile-writes branch March 14, 2024 19:14
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants