-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fnf error reporting #2078
Fnf error reporting #2078
Conversation
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2078 +/- ##
==========================================
- Coverage 90.93% 90.93% -0.01%
==========================================
Files 616 616
Lines 17370 17377 +7
Branches 3674 3676 +2
==========================================
+ Hits 15796 15801 +5
- Misses 1573 1575 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
…into fnf-error-reporting
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @ATorrise! Left a few comments around how we could make the error details look more similar to output of files upload
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reworking this and reversing the behavior that was originally requested in the issue.
After Timothy's comments are addressed, I would approve the PR.
Signed-off-by: Amber Torrise <[email protected]>
packages/cli/__tests__/zosjobs/__unit__/submit/Submit.shared.handler.unit.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Quality Gate passedIssues Measures |
packages/cli/__tests__/zosjobs/__unit__/submit/Submit.shared.handler.unit.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes do make sense!
LGTM! 😋
"engines": { | ||
"node": ">=18.12.0" | ||
}, | ||
"engines": { | ||
"node": ">=18.12.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confused as to why this was added twice here 😋
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Makes zosjob command errors more legible
How to Test
zowe jobs submit lf "noexist"
zowe files upload ftds local "remote"
Review Checklist
I certify that I have:
Additional Comments