Update prompting logic if port is 0 #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
anaxceron and
ATorrise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2077 +/- ##
==========================================
- Coverage 90.94% 90.93% -0.01%
==========================================
Files 616 616
Lines 17358 17359 +1
Branches 3571 3671 +100
==========================================
Hits 15786 15786
- Misses 1571 1572 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
anaxceron
approved these changes
Mar 5, 2024
|
traeok
approved these changes
Mar 5, 2024
adam-wolfe
approved these changes
Mar 5, 2024
zFernand0
reviewed
Mar 5, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Prompts the user for port if the port retrieved from the user's config is 0 (default for includeInTemplate, invalid)
Resolves #2075
How to Test
Install, set port to 0 in config for a service, observe prompting
Review Checklist
I certify that I have:
Additional Comments