Bump Engines in Packages #2074
Merged
Bump Engines in Packages #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <[email protected]>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
ATorrise and
adam-wolfe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2074 +/- ##
========================================
Coverage 91.09% 91.09%
========================================
Files 638 638
Lines 18840 18840
Branches 3924 3814 -110
========================================
Hits 17162 17162
Misses 1677 1677
Partials 1 1 ☔ View full report in Codecov by Sentry. |
gejohnston
approved these changes
Feb 27, 2024
Signed-off-by: Andrew W. Harn <[email protected]>
anaxceron
approved these changes
Feb 27, 2024
t1m0thyj
approved these changes
Feb 27, 2024
|
zFernand0
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
The engines string was incorrectly set, and some dependencies no longer support Node 16.
Sets the Engines string to the first Node 18 LTS version, which almost all dependencies support
The only exception to this is
ava, which is a dev dep of the Secrets SDK. That requires>=18.18.0.How to Test
Review Checklist
I certify that I have:
Additional Comments