Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfg): v3 port for schema management work #2060

Merged
merged 52 commits into from
Feb 22, 2024
Merged

Conversation

traeok
Copy link
Member

@traeok traeok commented Feb 21, 2024

What It Does

This is a v3 port of the schema management work done in #2001.

How to Test

Tests should pass

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Trae Yelovich <[email protected]>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (2f56753) 91.05% compared to head (735b0c9) 91.07%.

Files Patch % Lines
packages/imperative/src/config/src/ProfileInfo.ts 93.52% 9 Missing ⚠️
...ive/src/plugins/utilities/npm-interface/install.ts 90.47% 4 Missing ⚠️
...e/src/plugins/utilities/npm-interface/uninstall.ts 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2060      +/-   ##
==========================================
+ Coverage   91.05%   91.07%   +0.01%     
==========================================
  Files         638      638              
  Lines       18610    18824     +214     
  Branches     3857     3809      -48     
==========================================
+ Hits        16946    17144     +198     
- Misses       1663     1679      +16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Curious if we should have a new Changelog entry for the vNext release?
¯\_(ツ)_/¯

@traeok
Copy link
Member Author

traeok commented Feb 22, 2024

LGTM! 😋 Curious if we should have a new Changelog entry for the vNext release? ¯\_(ツ)_/¯

Thanks for the suggestion, I added it to the "Recent Changes" section of the changelog in 735b0c9 👍

@traeok traeok merged commit 830369f into next Feb 22, 2024
17 checks passed
@traeok traeok deleted the feat/v3/schema-mgmt branch February 22, 2024 17:56
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants