-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing yields and other fixes #2055
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2055 +/- ##
=======================================
Coverage 91.06% 91.07%
=======================================
Files 636 636
Lines 18967 18965 -2
Branches 3910 3976 +66
=======================================
- Hits 17273 17272 -1
+ Misses 1693 1692 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
Unfortunately, there is no good way to tell if this fixes all the bugs on SonarCloud or not. More work may need to be done after this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you hate it when you have to fix our test handlers? Thanks for working through all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for these fixes @awharn!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn for fixing these code smells especially the pesky Imperative.init
one 😋
What It Does
Fixes SonarCloud bugs
How to Test
Review Checklist
I certify that I have:
Additional Comments