Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing yields and other fixes #2055

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add missing yields and other fixes #2055

merged 1 commit into from
Feb 16, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 15, 2024

What It Does

Fixes SonarCloud bugs

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a4cba2) 91.06% compared to head (52ea428) 91.07%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ckages/imperative/src/imperative/src/Imperative.ts 97.29% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2055   +/-   ##
=======================================
  Coverage   91.06%   91.07%           
=======================================
  Files         636      636           
  Lines       18967    18965    -2     
  Branches     3910     3976   +66     
=======================================
- Hits        17273    17272    -1     
+ Misses       1693     1692    -1     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@awharn
Copy link
Member Author

awharn commented Feb 15, 2024

Unfortunately, there is no good way to tell if this fixes all the bugs on SonarCloud or not. More work may need to be done after this PR is merged.

@awharn awharn marked this pull request as ready for review February 15, 2024 21:34
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you hate it when you have to fix our test handlers? Thanks for working through all of them.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for these fixes @awharn!

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn for fixing these code smells especially the pesky Imperative.init one 😋

@awharn awharn merged commit 603fc28 into master Feb 16, 2024
19 of 21 checks passed
@awharn awharn deleted the fix-sonar-bugs branch February 16, 2024 19:01
@awharn awharn added the release-current Indicates that there is no new functionality being delivered label Feb 16, 2024
@awharn awharn restored the fix-sonar-bugs branch February 16, 2024 19:47
@awharn awharn mentioned this pull request Feb 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants