Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix technical currency [v2] #2049

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix technical currency [v2] #2049

merged 1 commit into from
Feb 12, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 12, 2024

What It Does

Updates the socks dependency to use ip-address instead of ip

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for updating the transitive dependency in the NPM-SW file

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5667624) 91.06% compared to head (e896d7a) 91.06%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         636      636           
  Lines       18955    18955           
  Branches     3973     3973           
=======================================
  Hits        17261    17261           
  Misses       1693     1693           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@awharn awharn merged commit 1b972d7 into master Feb 12, 2024
20 checks passed
@awharn awharn deleted the update-dependency-v2 branch February 12, 2024 22:18
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Feb 12, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants