Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to build offline tgz for CLI package #2031

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jan 30, 2024

What It Does
Adds script to build offline TGZ from source for CLI package. This should make it easier to test changes on another machine without having to clone the Git repo again 😋

How to Test
Run npm run package in top level of repo and try installing the TGZ that it built in the "dist" folder.

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfac3d9) 91.06% compared to head (957c244) 91.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2031    +/-   ##
========================================
  Coverage   91.06%   91.06%            
========================================
  Files         636      636            
  Lines       18953    18953            
  Branches     3861     3972   +111     
========================================
  Hits        17259    17259            
  Misses       1693     1693            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was able to build and install the tgz file using npm 👍 thanks @t1m0thyj!

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@t1m0thyj t1m0thyj merged commit c5a99d8 into master Feb 5, 2024
47 checks passed
@t1m0thyj t1m0thyj deleted the dev/add-package-script branch February 5, 2024 16:56
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants