-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profInfo): Fix secure property names being returned for wrong profile #2016
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
- Coverage 91.03% 91.02% -0.01%
==========================================
Files 636 636
Lines 18731 18737 +6
Branches 3907 3908 +1
==========================================
+ Hits 17051 17055 +4
- Misses 1679 1681 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned that using .startsWith
may not always be a good practice 😋
LGTM! 😋
@@ -14,7 +14,7 @@ export * from "./src/ConfigAutoStore"; | |||
export * from "./src/ConfigConstants"; | |||
export * from "./src/ConfigSchema"; | |||
export * from "./src/ConfigBuilder"; | |||
export * as ConfigUtils from "./src/ConfigUtils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the way in which we will have to eventually deal with the Imperative package.
Little by little, and as non-breaking changes. 😋
Thanks for moving the functions into a class 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these edge cases for the ProfileInfo APIs
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM! Thanks @t1m0thyj
What It Does
Fixes a small bug in
ConfigSecure.securePropsForProfile
where listing secure property names for "abcdef" profile also included property names for "abc" profileAlso moves top-level methods in
ConfigUtils.ts
inside a class to conform to best practices (thanks @zFernand0 for the suggestion).How to Test
Review Checklist
I certify that I have:
Additional Comments