Remove deprecated imperative constants, options, and methods - Imperative #1856

ATorrise · 2023-11-09T21:23:45Z

What It Does
Removes the following items marked as deprecated:

flattenCommandTreeWithAliases
requireKeytar
envVariablePrefix
AbstractAuthHandler.getPromptParams
BaseAuthHandler.getPromptParams
pluginHealthCheck
promptForInput and promptWithTimeout
Remove TODO comment regarding PMF_ROOT in the PluginManagementFacility

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Note

Changes were grouped into different commits to aid the review process.
This PR addresses zowe/imperative PR 970 but also internally Rally US925239. Rally has task to close out any related issues that are now irrelevant because of the deprecation. My method for determining relevant issues was to search issues on github with the names of the packages I've deprecated as a keyword. Any results I investigated. This method produced no issues to close out.

Signed-off-by: Amber Torrise <[email protected]>

codecov · 2023-11-09T22:05:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5181eb2) 91.04% compared to head (9de50fa) 91.03%.
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1856      +/-   ##
==========================================
- Coverage   91.04%   91.03%   -0.02%     
==========================================
  Files         636      636              
  Lines       18660    18615      -45     
  Branches     3871     3861      -10     
==========================================
- Hits        16989    16946      -43     
+ Misses       1670     1668       -2     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Amber Torrise <[email protected]>

ATorrise · 2023-11-09T22:18:25Z

@zFernand0 @gejohnston @t1m0thyj should i update the different changelogs and say what's been removed?

t1m0thyj · 2023-11-10T17:42:54Z

@zFernand0 @gejohnston @t1m0thyj should i update the different changelogs and say what's been removed?

Yes please 🙂 You can see an example of how we did it when deprecating old stuff in v1 here. We want to list the name of each deprecated method and its replacement.

Signed-off-by: Amber Torrise <[email protected]>

zFernand0 · 2023-11-14T14:50:29Z

Since the merging order caused this, I'm happy to help with merge conflicts 😋

…precatedImp Signed-off-by: zFernand0 <[email protected]>

Signed-off-by: zFernand0 <[email protected]>

…precatedImp Signed-off-by: zFernand0 <[email protected]>

Signed-off-by: zFernand0 <[email protected]>

sonarqubecloud · 2023-11-14T16:38:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

zFernand0

LGTM! 😋

gejohnston · 2023-11-10T20:19:11Z

packages/imperative/src/imperative/src/doc/IImperativeConfig.ts

-     * @type {string}
-     * @memberof IImperativeConfig
-     */
-    pluginHealthCheck?: string;


I think that we should have a separate story to remove the use of pluginHealthCheck from our zowe-cli-sample-plugin. The pluginHealthCheck property should also be removed from any real plugins that use it.

@gejohnston Sounds good. In a zowe wide search for pluginHealthCheck I get results in zowe-cli-sample-plugin, zowe-cli-scs-plugin, and the api-layer. Will create PRs for each of those repos and link back to this PR

github-actions · 2023-11-14T19:05:26Z

Release succeeded for the next branch. 🎉

The following packages have been published:

npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}

github-actions · 2023-11-16T22:24:29Z

Release succeeded for the next branch. 🎉

The following packages have been published:

npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]
npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}

pluginHealthCheck, PMF_ROOT comment, flattenCommandTreeWithAliaises

b52c7d2

Signed-off-by: Amber Torrise <[email protected]>

ATorrise changed the base branch from master to next November 9, 2023 21:24

.getPromptParams

40f2bd9

Signed-off-by: Amber Torrise <[email protected]>

ATorrise force-pushed the removeDeprecatedImp branch from e56c404 to 40f2bd9 Compare November 9, 2023 21:27

Amber Torrise added 2 commits November 9, 2023 16:28

requireKeytar

0e78a91

Signed-off-by: Amber Torrise <[email protected]>

ImperativeConfig.envVariablePrefix

42409bd

Signed-off-by: Amber Torrise <[email protected]>

Amber Torrise added 2 commits November 9, 2023 17:09

promptWithTimeout

6785bb4

Signed-off-by: Amber Torrise <[email protected]>

promptForInput

c94299c

Signed-off-by: Amber Torrise <[email protected]>

ATorrise marked this pull request as ready for review November 9, 2023 22:15

ATorrise requested review from t1m0thyj, zFernand0 and gejohnston November 10, 2023 15:44

ATorrise changed the title ~~Remove deprecated imperative constants, options, and methods~~ Remove deprecated imperative constants, options, and methods - Imperative Nov 10, 2023

ATorrise requested a review from adam-wolfe November 10, 2023 16:11

ATorrise force-pushed the removeDeprecatedImp branch from f8690a0 to 0e0bfbc Compare November 13, 2023 15:20

package.imperative changelog updates

cf11751

Signed-off-by: Amber Torrise <[email protected]>

ATorrise force-pushed the removeDeprecatedImp branch from 0e0bfbc to cf11751 Compare November 13, 2023 15:26

ATorrise self-assigned this Nov 13, 2023

fixing secure.handler.unit.test.ts

f214928

Signed-off-by: Amber Torrise <[email protected]>

zFernand0 added 4 commits November 14, 2023 14:56

Merge branch 'next' of https://github.com/zowe/zowe-cli into removeDe…

770f967

…precatedImp Signed-off-by: zFernand0 <[email protected]>

updates based on lint issues

cd676e3

Signed-off-by: zFernand0 <[email protected]>

Merge branch 'next' of https://github.com/zowe/zowe-cli into removeDe…

2655d01

…precatedImp Signed-off-by: zFernand0 <[email protected]>

messed up the merge commit

9de50fa

Signed-off-by: zFernand0 <[email protected]>

zFernand0 approved these changes Nov 14, 2023

View reviewed changes

gejohnston approved these changes Nov 14, 2023

View reviewed changes

zFernand0 merged commit ad2f748 into next Nov 14, 2023
20 checks passed

zFernand0 deleted the removeDeprecatedImp branch November 14, 2023 17:53

zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 14, 2023

github-actions bot added the released label Nov 14, 2023

t1m0thyj removed the released label Nov 16, 2023

github-actions bot added the released label Nov 16, 2023

t1m0thyj mentioned this pull request Nov 30, 2023

Remove deprecated for core cli #1981

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated imperative constants, options, and methods - Imperative #1856

Remove deprecated imperative constants, options, and methods - Imperative #1856

ATorrise commented Nov 9, 2023 •

edited

Loading

codecov bot commented Nov 9, 2023 •

edited

Loading

ATorrise commented Nov 9, 2023 •

edited

Loading

t1m0thyj commented Nov 10, 2023 •

edited

Loading

zFernand0 commented Nov 14, 2023

sonarqubecloud bot commented Nov 14, 2023

zFernand0 left a comment

gejohnston Nov 10, 2023

ATorrise Nov 16, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 16, 2023

Remove deprecated imperative constants, options, and methods - Imperative #1856

Remove deprecated imperative constants, options, and methods - Imperative #1856

Conversation

ATorrise commented Nov 9, 2023 • edited Loading

codecov bot commented Nov 9, 2023 • edited Loading

Codecov Report

ATorrise commented Nov 9, 2023 • edited Loading

t1m0thyj commented Nov 10, 2023 • edited Loading

zFernand0 commented Nov 14, 2023

sonarqubecloud bot commented Nov 14, 2023

zFernand0 left a comment

Choose a reason for hiding this comment

gejohnston Nov 10, 2023

Choose a reason for hiding this comment

ATorrise Nov 16, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 16, 2023

ATorrise commented Nov 9, 2023 •

edited

Loading

codecov bot commented Nov 9, 2023 •

edited

Loading

ATorrise commented Nov 9, 2023 •

edited

Loading

t1m0thyj commented Nov 10, 2023 •

edited

Loading