Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octorelease changelog updates #1847

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Octorelease changelog updates #1847

merged 4 commits into from
Nov 13, 2023

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Nov 8, 2023

What It Does
Addressing warnings in zowe-actions/octorelease@v1. All changelogs had the following comments added:

## Recent Changes

- Breaking: First major version bump for V3

Review Checklist
I certify that I have:

@ATorrise ATorrise self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small things, then I think this PR should be good to go. :)

packages/cli/CHANGELOG.md Show resolved Hide resolved
packages/imperative/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve (after Andrew's comments are addressed)

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, will approve once @awharn's requests are addressed 🙂 Thanks @ATorrise!

packages/zosfiles/CHANGELOG.md Show resolved Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise force-pushed the octoreleaseChangelog branch from 97b14f3 to a52a0f0 Compare November 13, 2023 16:52
@ATorrise ATorrise requested a review from awharn November 13, 2023 16:53
@ATorrise
Copy link
Contributor Author

@awharn @gejohnston @traeok sorry guys I didn't see your comments

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ATorrise ATorrise merged commit cb3859c into next Nov 13, 2023
47 checks passed
@ATorrise ATorrise deleted the octoreleaseChangelog branch November 13, 2023 20:02
@zFernand0 zFernand0 added the release-major Indicates a major breaking change will be introduced label Nov 13, 2023
@github-actions github-actions bot removed the release-major Indicates a major breaking change will be introduced label Nov 13, 2023
Copy link

Release failed for the next branch. 😢

Error: The process '/opt/hostedtoolcache/node/20.9.0/x64/bin/npm' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:863:21)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants