Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pr1840 #1841

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Migrate pr1840 #1841

merged 5 commits into from
Nov 7, 2023

Conversation

zFernand0
Copy link
Member

What It Does

This is the first PR of many more to come in before the Zowe V3 GA date.
The intention is to migrate the changes done in the following PR:

How to Test

  • Verify that the pipeline can go for longer than 75 minutes
  • Verify that the Sonar reporter is successfully reporting based on test results

In other words, let's give the pipeline some time to complete. 😋

Review Checklist
I certify that I have:

Additional Comments

I wanted to have this as an example of a clean migration from master to next.
The will be PRs where conflicts between the two branches will arise, so be cautious during any and all migration PRs 😋

awharn and others added 4 commits October 30, 2023 20:38
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 357 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@zFernand0 zFernand0 marked this pull request as ready for review November 1, 2023 16:00
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zFernand0
Copy link
Member Author

Should this PR have the release-major label, so that we can have a 8.0.0-next.timestamp in our GH releases and eventually in public NPM ?

@t1m0thyj
Copy link
Member

t1m0thyj commented Nov 2, 2023

Should this PR have the release-major label, so that we can have a 8.0.0-next.timestamp in our GH releases and eventually in public NPM ?

I'm not opposed to merging this PR with release-major as long as we're aware of the implications. This would mean that Imperative has a 6.0.0-next.timestamp release published until we successfully complete the migration of Imperative into the Core SDK.

@zFernand0
Copy link
Member Author

zFernand0 commented Nov 2, 2023

Should this PR have the release-major label, so that we can have a 8.0.0-next.timestamp in our GH releases and eventually in public NPM ?

I'm not opposed to merging this PR with release-major as long as we're aware of the implications. This would mean that Imperative has a 6.0.0-next.timestamp release published until we successfully complete the migration of Imperative into the Core SDK.

Since the versionIndependent was removed in the vNext branch already, we should end up with an Imperative 8.0.0-next.timestamp 😋
However, I believe that this is what we want since it's not set in stone that the Imperative package will be merged into core. 😋

@zFernand0 zFernand0 merged commit a624c1a into next Nov 7, 2023
20 checks passed
@zFernand0 zFernand0 deleted the migrate-pr1840 branch November 7, 2023 13:49
@zFernand0 zFernand0 added the release-major Indicates a major breaking change will be introduced label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-major Indicates a major breaking change will be introduced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants