Add note about Cargo build requirement #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adam-wolfe <[email protected]>
Signed-off-by: adam-wolfe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
Kudos, SonarCloud Quality Gate passed!
|
zFernand0
approved these changes
Oct 30, 2023
README.md
Outdated
| @@ -49,7 +49,7 @@ Versioning conventions for Zowe CLI and Plug-ins| [Versioning Guidelines](./docs | |||
| <br/> | |||
|
|
|||
| ## **Building Zowe CLI From Source** | |||
| Zowe CLI requires NPM version 7 to install from source. Before proceeding, check your NPM version with `npm --version` and if it's older than 7.x, update with `npm install -g npm`. | |||
| Zowe CLI requires NPM version 7 and Cargo version 1.72.0 (or newer) to build from source. Before proceeding, check your NPM version with `npm --version` and if it's older than 7.x, update with `npm install -g npm`. To check your version of Cargo, run `cargo --version`. Cargo can be installed using rustup: [https://rustup.rs/](https://rustup.rs/). To update Cargo, run the `rustup update` command. | |||
There was a problem hiding this comment.
is it ok to modify the npm version number to at least 8?
Nobody should be using anything lower than 9 at this point since Node started to bundle 9 with node 18 😋
https://nodejs.org/en/download/releases
Signed-off-by: adam-wolfe <[email protected]>
zFernand0
approved these changes
Oct 30, 2023
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
traeok
approved these changes
Oct 30, 2023
awharn
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Adds information to README.md stating that Cargo 1.72.0 (or newer) is required in order to build Zowe CLI from source.
How to Test
Check README.md at the root of the repository and in packages/cli/README.md.
Review Checklist
I certify that I have:
Additional Comments