Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fix for #1722 #1833

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Implement fix for #1722 #1833

merged 2 commits into from
Oct 27, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 26, 2023

What It Does
Implements fix for #1722 by not lowercasing the specified directory

How to Test
Run zowe files download dsm specifying a mixed case directory with the latest version of Zowe CLI on NPM and a built version of this PR.

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/zosfiles/src/methods/download/Download.ts 96.19% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn 😁

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zFernand0 zFernand0 merged commit 7009f27 into master Oct 27, 2023
20 checks passed
@zFernand0 zFernand0 deleted the fix-1722 branch October 27, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants