-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secrets): Use core-foundation-rs
instead of security-framework
for macOS logic
#1811
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
9b89ba3
to
e4967e1
Compare
Signed-off-by: Trae Yelovich <[email protected]>
e4967e1
to
2d1bb59
Compare
Signed-off-by: Trae Yelovich <[email protected]>
…tring Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
SonarCloud security hotspot is a false positive as it is a credential used for unit tests. |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
core-foundation-rs
crate and FFI calls instead of thesecurity-framework
crate, assecurity-framework
has been archived.7.18.6
of the Secrets SDK that contains the above changes.libsecret::secret_value_unref
call when interacting with items (causes segfault in scenarios where only one match is found)Note: Once the required # of reviews is met, I'm going to publish Secrets SDK 7.18.6 before merging.
How to Test
Try to build, install, and use Zowe CLI using this PR on macOS. The CLI should work as expected using secure credentials.
If you want to test the Linux fix for edge-cases with the
findCredentials
function, install the Secrets SDK as a global package, then save the following script as a.js
file and execute it with Node (node test.js
):The script should run without any errors or segmentation faults printed to stdout.
Review Checklist
I certify that I have: