Merge pull request #2132 from zowe/add-pds-search

Make all requested changes

packages/cli/__tests__/zosfiles/__integration__/search/ds/cli.files.search.ds.integration.test.ts

@@ -50,7 +50,7 @@ describe("Search data sets", () => {
         const response = runCliScript(shellScript, TEST_ENVIRONMENT, ["IBMUSER.*"]);
         expect(response.status).toBe(1);
         expect(response.stderr.toString()).toContain("Missing Positional Argument");
-        expect(response.stderr.toString()).toContain("search-string");
+        expect(response.stderr.toString()).toContain("searchString");
     });
 
     it("should fail if the maximum concurrent requests are out of range 1", () => {
@@ -59,18 +59,18 @@ describe("Search data sets", () => {
         expect(response.status).toBe(1);
         expect(response.stderr.toString()).toContain("Invalid numeric value specified for option");
         expect(response.stderr.toString()).toContain("max-concurrent-requests");
-        expect(response.stderr.toString()).toContain("1 and 99999");
+        expect(response.stderr.toString()).toContain("1 and 100");
         expect(response.stderr.toString()).toContain("-1");
     });
 
     it("should fail if the maximum concurrent requests are out of range 2", () => {
         const shellScript = path.join(__dirname, "__scripts__", "command", "command_search_data_sets.sh");
-        const response = runCliScript(shellScript, TEST_ENVIRONMENT, ["IBMUSER.*", "TESTDATA", "--max-concurrent-requests 100000"]);
+        const response = runCliScript(shellScript, TEST_ENVIRONMENT, ["IBMUSER.*", "TESTDATA", "--max-concurrent-requests 101"]);
         expect(response.status).toBe(1);
         expect(response.stderr.toString()).toContain("Invalid numeric value specified for option");
         expect(response.stderr.toString()).toContain("max-concurrent-requests");
-        expect(response.stderr.toString()).toContain("1 and 99999");
-        expect(response.stderr.toString()).toContain("100000");
+        expect(response.stderr.toString()).toContain("1 and 100");
+        expect(response.stderr.toString()).toContain("101");
     });
 
 });

packages/cli/__tests__/zosfiles/__unit__/download/am/__snapshots__/AllMembers.definition.unit.test.ts.snap

@@ -53,7 +53,7 @@ The maximum number of TSO address spaces have been created. When you specify 0,
     "name": "max-concurrent-requests",
     "numericValueRange": Array [
       0,
-      99999,
+      100,
     ],
     "type": "number",
   },

packages/cli/__tests__/zosfiles/__unit__/download/dsm/__snapshots__/DataSetMatching.definition.unit.test.ts.snap

@@ -72,7 +72,7 @@ The maximum number of TSO address spaces have been created. When you specify 0,
     "name": "max-concurrent-requests",
     "numericValueRange": Array [
       0,
-      99999,
+      100,
     ],
     "type": "number",
   },

packages/cli/__tests__/zosfiles/__unit__/download/ussdir/__snapshots__/UssDir.definition.unit.test.ts.snap

@@ -80,7 +80,7 @@ The maximum number of TSO address spaces have been created. When you specify 0,
     "name": "max-concurrent-requests",
     "numericValueRange": Array [
       0,
-      99999,
+      100,
     ],
     "type": "number",
   },

packages/cli/__tests__/zosfiles/__unit__/search/ds/__snapshots__/Datasets.definition.unit.test.ts.snap

@@ -29,7 +29,7 @@ Array [
     "name": "max-concurrent-requests",
     "numericValueRange": Array [
       1,
-      99999,
+      100,
     ],
     "type": "number",
   },

packages/cli/__tests__/zosfiles/__unit__/upload/dtu/__snapshots__/DirToUSS.definition.unit.test.ts.snap

@@ -61,7 +61,7 @@ The maximum number of TSO address spaces have been created. When you specify 0,
     "name": "max-concurrent-requests",
     "numericValueRange": Array [
       0,
-      99999,
+      100,
     ],
     "type": "number",
   },

packages/cli/src/zosfiles/-strings-/en.ts

@@ -385,7 +385,7 @@ export default {
                     `(e.g. "ibmuser.j*.old" matches "ibmuser.jcl.old" but not "ibmuser.jcl.very.old")
                     ${TextUtils.chalk.yellow("**")}: matches any number of characters within any number of data set name qualifiers ` +
                     `(e.g. "ibmuser.**.old" matches both "ibmuser.jcl.old" and "ibmuser.jcl.very.old")
-                    However, the pattern cannot begin with any of these sequences.You can specify multiple patterns separated by commas, ` +
+                    However, the pattern cannot begin with any of these sequences. You can specify multiple patterns separated by commas, ` +
                     `for example "ibmuser.**.cntl,ibmuser.**.jcl"`
                 },
                 EXAMPLES: {
@@ -601,7 +601,7 @@ export default {
                     `(e.g. "ibmuser.j*.old" matches "ibmuser.jcl.old" but not "ibmuser.jcl.very.old")
                     ${TextUtils.chalk.yellow("**")}: matches any number of characters within any number of data set name qualifiers ` +
                     `(e.g. "ibmuser.**.old" matches both "ibmuser.jcl.old" and "ibmuser.jcl.very.old")
-                    However, the pattern cannot begin with any of these sequences.You can specify multiple patterns separated by commas, ` +
+                    However, the pattern cannot begin with any of these sequences. You can specify multiple patterns separated by commas, ` +
                     `for example "ibmuser.**.cntl,ibmuser.**.jcl"`
                 },
                 OPTIONS: {

packages/cli/src/zosfiles/download/Download.options.ts

@@ -17,7 +17,7 @@ import i18nTypings from "../-strings-/en";
 const strings = (require("../-strings-/en").default as typeof i18nTypings).DOWNLOAD.OPTIONS;
 
 /** @internal */
-export const maxConcurrentRequestsMaxValue = 99999;
+export const maxConcurrentRequestsMaxValue = 100;
 
 /**
  * Object containing all options to be used by the Download data set API

packages/cli/src/zosfiles/search/ds/DataSets.definition.ts

@@ -39,7 +39,7 @@ export const DataSetsDefinition: ICommandDefinition = {
             required: true
         },
         {
-            name: "search-string",
+            name: "searchString",
             description: strings.OPTIONS.SEARCHSTRING,
             type: "string",
             required: true

packages/cli/src/zosfiles/upload/Upload.options.ts

@@ -10,14 +10,13 @@
 */
 
 import { ICommandOptionDefinition } from "@zowe/imperative";
+import { maxConcurrentRequestsMaxValue } from "../download/Download.options";
 
 import i18nTypings from "../-strings-/en";
 
 // Does not use the import in anticipation of some internationalization work to be done later.
 const strings = (require("../-strings-/en").default as typeof i18nTypings).UPLOAD.OPTIONS;
 
-const maxConcurrentRequestsMaxValue = 99999;
-
 /**
  * Object containing all options to be used by the Upload API
  */

packages/zosfiles/src/methods/search/doc/ISearchMatchLocation.ts

@@ -13,7 +13,6 @@
  * This interface defines the information that is stored in the download data set API return object
  */
 export interface ISearchMatchLocation {
-
     /**
      * The line number that the match was found in
      */