-
Notifications
You must be signed in to change notification settings - Fork 3
Add deprecation notices, deprecation warning on install #66
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## zowe-v1-lts #66 +/- ##
============================================
Coverage 90.31% 90.31%
============================================
Files 40 40
Lines 764 764
Branches 191 191
============================================
Hits 690 690
Misses 72 72
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Don't worry about the failing audit check - because we have our peer dependency on an early version of Imperative, Node is trying to install that particular version, which has dependencies on vulnerable versions of semver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Q: do we plan to publish this as a patch (and then deprecate the entire package) ?
Signed-off-by: Andrew W. Harn <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Adds deprecation notice to the readme and on post-install, which may not be visible on newer versions of node
How to Test
Install the plug-in on Node 12
Review Checklist
I certify that I have:
Additional Comments