Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Add deprecation notices, deprecation warning on install #66

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 7, 2024

What It Does

Adds deprecation notice to the readme and on post-install, which may not be visible on newer versions of node

How to Test

Install the plug-in on Node 12

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b46c905) 90.31% compared to head (68ecb5c) 90.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v1-lts      #66   +/-   ##
============================================
  Coverage        90.31%   90.31%           
============================================
  Files               40       40           
  Lines              764      764           
  Branches           191      191           
============================================
  Hits               690      690           
  Misses              72       72           
  Partials             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awharn
Copy link
Member Author

awharn commented Feb 7, 2024

Don't worry about the failing audit check - because we have our peer dependency on an early version of Imperative, Node is trying to install that particular version, which has dependencies on vulnerable versions of semver.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Q: do we plan to publish this as a patch (and then deprecate the entire package) ?

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@awharn awharn merged commit 31ac072 into zowe-v1-lts Feb 7, 2024
15 of 16 checks passed
@awharn awharn deleted the deprecate-v1-lts branch February 7, 2024 20:38
@awharn awharn added the release-patch Indicates a patch to existing code will be applied label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-patch Indicates a patch to existing code will be applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants