Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

updating workflows - lts #57

Merged
merged 8 commits into from
May 15, 2023
Merged

updating workflows - lts #57

merged 8 commits into from
May 15, 2023

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented May 5, 2023

Action Description
#6 update all workflows to remove deprecation warnings, octorelease updates
#7 remove Node 14 from workflow matrix

Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise self-assigned this May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d850bab) 90.31% compared to head (9d06b5b) 90.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v1-lts      #57   +/-   ##
============================================
  Coverage        90.31%   90.31%           
============================================
  Files               40       40           
  Lines              764      764           
  Branches           191      191           
============================================
  Hits               690      690           
  Misses              72       72           
  Partials             2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ATorrise ATorrise changed the title updating lts workflows updating workflows - lts May 8, 2023
.github/workflows/changelog.yml Show resolved Hide resolved
.github/workflows/codeql.yml Show resolved Hide resolved
.github/workflows/zowe-cli-plugin.yml Show resolved Hide resolved
.github/workflows/zowe-cli-plugin.yml Show resolved Hide resolved
ATorrise added 4 commits May 9, 2023 09:45
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise requested review from zFernand0 and t1m0thyj May 9, 2023 17:56
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version of the CLI in this branch (to remove the Audit failures)?
@t1m0thyj, thoughts?

.github/workflows/changelog.yml Show resolved Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise requested a review from zFernand0 May 11, 2023 15:59
@t1m0thyj
Copy link
Member

t1m0thyj commented May 11, 2023

Should we update the version of the CLI in this branch (to remove the Audit failures)? @t1m0thyj, thoughts?

Yeah we probably should 🙂 @ATorrise Could you run npm audit fix to update the npm-shrinkwrap.json and resolve the vulnerability that's causing the Audit check to fail?

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve once the Audit check is passing

@ATorrise ATorrise requested review from t1m0thyj and zFernand0 and removed request for t1m0thyj and zFernand0 May 11, 2023 16:42
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you run npm audit fix --force ?
if so, it might have applied breaking changes when updating typedoc.
nothing wrong, but we may want to address the typescript dependency, i.e. update to "typescript": "^4.9.5"

@t1m0thyj
Copy link
Member

If we update typedoc through npm audit fix --force, it will require us to update a number of other dev deps as well like typescript, ts-jest, and jest so they are all compatible with each other. I'm not opposed to doing this, but don't want to expand the scope of this PR either 😅

@ATorrise It may be easiest to revert back to the last commit before the npm audit (b894eea), and then run npm audit fix again without the --force flag to update only the Imperative package.

@ATorrise ATorrise force-pushed the updateWorkFlowslts branch from b050f4b to b894eea Compare May 12, 2023 14:18
.github/workflows/zowe-cli-plugin.yml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zFernand0 zFernand0 merged commit e64edac into zowe-v1-lts May 15, 2023
@zFernand0 zFernand0 deleted the updateWorkFlowslts branch May 15, 2023 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants