-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
ATorrise
commented
May 5, 2023
Action | Description |
---|---|
#6 | update all workflows to remove deprecation warnings, octorelease updates |
#7 | remove Node 14 from workflow matrix |
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## zowe-v1-lts #57 +/- ##
============================================
Coverage 90.31% 90.31%
============================================
Files 40 40
Lines 764 764
Branches 191 191
============================================
Hits 690 690
Misses 72 72
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the version of the CLI in this branch (to remove the Audit failures)?
@t1m0thyj, thoughts?
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve once the Audit check is passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you run npm audit fix --force
?
if so, it might have applied breaking changes when updating typedoc
.
nothing wrong, but we may want to address the typescript
dependency, i.e. update to "typescript": "^4.9.5"
If we update @ATorrise It may be easiest to revert back to the last commit before the |
b050f4b
to
b894eea
Compare
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |