This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Fix daemon mode prompting, remove API call causing error #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## next #42 +/- ##
==========================================
- Coverage 91.84% 91.82% -0.02%
==========================================
Files 41 41
Lines 417 416 -1
Branches 29 28 -1
==========================================
- Hits 383 382 -1
Misses 32 32
Partials 2 2
Continue to review full report at Codecov.
|
Signed-off-by: Andrew W. Harn <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
zFernand0
approved these changes
Apr 6, 2022
| * | ||
| * @returns {Promise<IIMSApiResponse>} The response from the underlying ims api call. | ||
| */ | ||
| public abstract async processWithSession( | ||
| commandParameters: IHandlerParameters, | ||
| session: ImsSession, | ||
| imsProfile: IProfile | ||
| session: ImsSession | ||
| ): Promise<IIMSApiResponse>; |
There was a problem hiding this comment.
I initially thought this could've been a breaking change but since we do not export anything on the src/cli folder, we are fine 😋
Still good to do as part of vNext though since it's kind of a big change
gejohnston
approved these changes
Apr 6, 2022
t1m0thyj
approved these changes
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew W. Harn [email protected]