Fix ability to use attls #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls for use with attls Signed-off-by: 1000TurquoisePogs <[email protected]>
…rity plugin as 5th arg. Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
sakshibobade21
approved these changes
May 28, 2024
lib/util.js
Outdated
| } | ||
|
|
||
| function isClientAttls(zoweConfig) { | ||
| let clientGlobalAttls = zoweConfig.zowe.network?.client?.tls?.attls; | ||
| let clientLocalAttls zoweConfig.components['app-server'].zowe?.network?.client?.tls?.attls; |
There was a problem hiding this comment.
We need "=" after let clientLocalAttls
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix not being able to run in an http mode and still do https client calls for use with attls
ATTLS used to work fine but we've had regressions about using http.
There are conditionals in the code where if http exists, https will not be used.
There are conditionals in the code that detect if https exists, and to not use http if so.
These are not quite correct and should be based upon attls use.
The server can be HTTP for attls, yet still wish to issue HTTPS calls outward, and therefore want certificates still.
This PR depends upon zowe/zowe-install-packaging#3463 and zowe/zlux-app-server#300