Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unused auth plugins #504

Merged
merged 10 commits into from
Oct 10, 2023
Merged

Skip unused auth plugins #504

merged 10 commits into from
Oct 10, 2023

Conversation

1000TurquoisePogs
Copy link
Member

Skip unused auth plugins. Also fix a bug where _internal contents were not loaded at dataservice init time.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

TBD

@1000TurquoisePogs
Skip unused auth plugins. Fix a bug where _internal contents were not…
cd1cf6a 
… loaded at dataservice init time.

Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs
Update changelog
43fac66 
Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs 1000TurquoisePogs changed the title Skip unused auth plugins. F Skip unused auth plugins Sep 20, 2023
1000TurquoisePogs
1000TurquoisePogs commented Sep 26, 2023
View reviewed changes
lib/auth-manager.js Outdated
}
}
if (!categoryFound) {
bootstrapLogger.info(`Plugin ${plugin.identifier} will not be loaded because no dataservices requested it.`);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to assign message id

timgerstel
timgerstel approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@timgerstel timgerstel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on webex with Sean, approved

@1000TurquoisePogs 1000TurquoisePogs merged commit 09b8b18 into v2.x/staging Oct 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgerstel timgerstel timgerstel approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1000TurquoisePogs @timgerstel