Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used ViewPort Events to Resize the DiffEditor #335

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

Priyansh61
Copy link

Proposed changes

This PR addresses Issue: zowe/zlux#851

This PR depends upon the following PRs: NA

resize-2023-06-16_19.00.23.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but there are now 8 occurrences of .layout( ) methods in zlux-editor
having separate sets for editor.layout versus diffEditor.layout is fine but chances are at least 1 or 2 of the 8 occurrences are duplicating efforts/doing nothing. Could you remove some of them?

@DivergentEuropeans
Copy link
Member

Up to you how you wish to scope this PR: stay within diffEditor stuff, remove the unneeded diffEditor calls & leave the regular Editor rendering code for a different PR or a different person, or handle both in this PR. I'm fine with either one 👍

@Priyansh61
Copy link
Author

Priyansh61 commented Jun 30, 2023

@DivergentEuropeans I have removed the unused instances of .layout() and also merged the suscriber streams for both the diff editor and editor, the commits have been pushed to this branch but I dont know why it is not visible in the PR, but the commits are there in the branch when you check it on the branch. There might be something wrong with github right now, so I am assuming everything will be alright till the time you review the PR, please let me know if the commits are still not visible when you view it.

@DivergentEuropeans DivergentEuropeans merged commit 4cc2f6f into v2.x/staging Oct 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants