-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used ViewPort Events to Resize the DiffEditor #335
Used ViewPort Events to Resize the DiffEditor #335
Conversation
Signed-off-by: Priyansh61 <[email protected]>
Signed-off-by: Priyansh61 <[email protected]>
Signed-off-by: Priyansh61 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but there are now 8 occurrences of .layout( )
methods in zlux-editor
having separate sets for editor.layout
versus diffEditor.layout
is fine but chances are at least 1 or 2 of the 8 occurrences are duplicating efforts/doing nothing. Could you remove some of them?
Up to you how you wish to scope this PR: stay within diffEditor stuff, remove the unneeded diffEditor calls & leave the regular Editor rendering code for a different PR or a different person, or handle both in this PR. I'm fine with either one 👍 |
Signed-off-by: Priyansh61 <[email protected]>
@DivergentEuropeans I have removed the unused instances of .layout() and also merged the suscriber streams for both the diff editor and editor, the commits have been pushed to this branch but I dont know why it is not visible in the PR, but the commits are there in the branch when you check it on the branch. There might be something wrong with github right now, so I am assuming everything will be alright till the time you review the PR, please let me know if the commits are still not visible when you view it. |
Proposed changes
This PR addresses Issue: zowe/zlux#851
This PR depends upon the following PRs: NA
resize-2023-06-16_19.00.23.mp4
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments