Update build script to pass more strict npm installs/npm builds (#136)

* fix node version (#119) Signed-off-by: James Struga <[email protected]> * Added legacy npm install for out of date RS's Carbon Components Signed-off-by: Leanid Astrakou <[email protected]> --------- Signed-off-by: James Struga <[email protected]> Signed-off-by: Leanid Astrakou <[email protected]> Co-authored-by: zowe-robot <[email protected]> Co-authored-by: James Struga <[email protected]>
zowe · Mar 29, 2024 · 3ba7cda · 3ba7cda
1 parent e4bd796
commit 3ba7cda
Showing 1 changed file with 29 additions and 1 deletion.
diff --git a/build_ng2.xml b/build_ng2.xml
@@ -30,7 +30,8 @@
       <param name="buildType" value="build"/>
     </antcall>
 
-    <antcall target="npmInstall">
+    <!-- TODO: Update component's dependencies such that install passes with npmInstall -->
+    <antcall target="npmInstallLegacy">
       <param name="packagejson.Location" value="${capstone}/zlux-app-manager/system-apps/admin-notification-app/webClient"/>
     </antcall>
     <antcall target="npmBuild">
@@ -238,6 +239,33 @@
     </if>
   </target>
 
+  <target name="npmInstallLegacy" depends="package.jsonExists" if="package.jsonPresent">
+    <exec executable="cmd" 
+          dir="${packagejson.Location}" 
+          osfamily="windows"
+          resultproperty="rc"
+          searchpath="true">
+      <arg line="/c npm install --legacy-peer-deps"/>
+    </exec>
+    <exec executable="npm" 
+          dir="${packagejson.Location}"
+          osfamily="unix"
+          resultproperty="rc"
+          searchpath="true">
+      <arg line="install"/>
+    </exec>
+
+    <echo message="Result of install in ${packagejson.Location} is: ${rc}"/>
+    <if>
+      <not>
+        <equals arg1="${rc}" arg2="0"/>
+      </not>
+      <then>
+        <fail message="Error with npm install in ${packagejson.Location}" />
+      </then>
+    </if>
+  </target>
+
   <target name="npmRunI18n" depends="package.jsonExists" if="package.jsonPresent">
     <exec executable="cmd"
           dir="${packagejson.Location}"