New Desktop ID #614
New Desktop ID #614
Conversation
…desktop. Allow ?use-v2-desktop=1 to launch v2 desktop Signed-off-by: 1000TurquoisePogs <[email protected]>
| if (desktops.length == 0) { | ||
| console.error("ZWED5012E - No desktops available to bootstrap."); | ||
| } else if (useV2Desktop) { | ||
| console.error("ZWED5324I - The requested Desktop version (V2) is in maintenance mode. To use the newest Desktop version instead, remove the query parameter 'use-v2-desktop'."); |
There was a problem hiding this comment.
i should leave a code comment here: i want this to be colored, but its not really an error.
also change to console.warn
There was a problem hiding this comment.
So like we touched about on Friday's call, there's utility functions for this @1000TurquoisePogs. The window.location.search stuff is not important enough for duplication but here it is if you want better organization:
getAllApp2AppArgsFromURL( ) in
zlux-app-manager\virtual-desktop\src\app\start-url-manager\start-url-manager.service.ts
What is relatively important is there's a registration process for stuff like this that should be followed, see:
zlux-app-manager\bootstrap\src\main.ts
processApp2AppArgs( )
URL query params get assigned values in window global object and then those get checked for future reference
| if (desktops.length == 0) { | ||
| console.error("ZWED5012E - No desktops available to bootstrap."); | ||
| } else if (useV2Desktop) { | ||
| console.error("ZWED5324I - The requested Desktop version (V2) is in maintenance mode. To use the newest Desktop version instead, remove the query parameter 'use-v2-desktop'."); |
There was a problem hiding this comment.
So like we touched about on Friday's call, there's utility functions for this @1000TurquoisePogs. The window.location.search stuff is not important enough for duplication but here it is if you want better organization:
getAllApp2AppArgsFromURL( ) in
zlux-app-manager\virtual-desktop\src\app\start-url-manager\start-url-manager.service.ts
What is relatively important is there's a registration process for stuff like this that should be followed, see:
zlux-app-manager\bootstrap\src\main.ts
processApp2AppArgs( )
URL query params get assigned values in window global object and then those get checked for future reference
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "identifier": "org.zowe.zlux.ng2desktop", | |||
| "identifier": "org.zowe.zlux.ivydesktop", | |||
There was a problem hiding this comment.
There is a lot of places we now need to change this:
zlux-app-manager\virtual-desktop\src\app\shared\logger.ts
zlux-app-manager\virtual-desktop\src\app\start-url-manager\start-url-manager.service.ts
zlux-app-manager\virtual-desktop\src\app\window-manager\mvd-window-manager\personalization-panel\personalization-panel.component.ts possibly?
probably others
so do a text search & see if it makes sense to change there too
There was a problem hiding this comment.
logger & start-url-manager = done
others = no, they seem to have different ids. "org.zowe.zlux.ng2desktop.settings" is not "org.zowe.zlux.ng2desktop". Changing it could have consequences like breaking saved settings.
That may be desirable at some point in the future but I don't see the case for it now.
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
|
@DivergentEuropeans when you suggested using I understand that boostrap interprets query params in a certain way and assigns globals. Let's talk about: why add onto that? |
Signed-off-by: 1000TurquoisePogs <[email protected]>
1000TurquoisePogs
changed the base branch from
v3.x/staging
to
feature/v3/new-desktop-with-changes
DivergentEuropeans
merged commit 96720b4
into
feature/v3/new-desktop-with-changes
This PR changes some of the bootstrapping code so that we can load the new desktop with distinct ID.
This PR also allows the old desktop to be switched to via query parameter "?use-v2-desktop=1"