Skip to content

Commit

Permalink
added step in pipeline that checks if code is valid via eslint
Browse files Browse the repository at this point in the history
Signed-off-by: Justin Santer <[email protected]>
  • Loading branch information
Justin Santer committed Feb 19, 2022
1 parent 9e5d04c commit bf5e9ab
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ jobs:
- name: '[Build] Node.js project build'
run: npm run build

- name: '[Lint] Ensure consistent code styling'
run: npm run lint

- name: '[Test] Node.js project unit tests'
run: npm test

- name: '[Lint] Check if code has any warnings/errors/non-standard styling'
run: npm run check-lint

deploy:
runs-on: ubuntu-latest
needs: [check-permission, build-test]
Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
"description": "Top-level package for ZEBRA packages",
"main": "index.js",
"scripts": {
"prebuild": "npm install --include=dev && foreach -g \"./packages/*/package.json\" -x \"npm install --prefix #{dir} --include=dev\"",
"build": "foreach -g \"./packages/*/package.json\" -x \"npm run --prefix #{dir} build\"",
"test": "foreach -g \"./packages/*/package.json\" -x \"npm test --prefix #{dir}\"",
"prebuild": "npm install --include=dev && foreach -g \"./packages/*/package.json\" -x \"npm install --prefix #{dir} --include=dev\" --concurrent",
"build": "foreach -g \"./packages/*/package.json\" -x \"npm run --prefix #{dir} build\" --concurrent",
"test": "foreach -g \"./packages/*/package.json\" -x \"npm test --prefix #{dir}\" --concurrent",
"prepare": "husky install",
"lint": "pretty-quick --staged && lint-staged"
"lint": "pretty-quick --staged && lint-staged",
"check-lint": "npx eslint packages --ext .ts"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit bf5e9ab

Please sign in to comment.