Added missing syslog check gap for WTO #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leanid Astrakou <[email protected]>
DivergentEuropeans
requested review from
JoeNemo,
1000TurquoisePogs and
ifakhrutdinov
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Leanid Astrakou <[email protected]>
1000TurquoisePogs
approved these changes
Oct 23, 2023
| @@ -782,6 +782,7 @@ static void *handle_comp_comm(void *args) { | |||
|
|
|||
| while (next_line) { | |||
| printf("%s\n", next_line); | |||
| check_for_and_print_sys_message(next_line); | |||
There was a problem hiding this comment.
check_for_and_print_sys_message does not exclude messages that start with "ZWE_zowe_sysMessages_", but should, because though it does print syslog messages you want, it also prints debug stuff you dont want:
11.20.25 S0542560 +ZWEL0021I Zowe Launcher starting
11.20.40 S0542560 +ZWEL0018I Zowe instance prepared successfully
11.20.49 S0542560 +ZWEL0006I starting components
11.20.49 S0542560 +ZWEL0001I component app-server started
11.20.49 S0542560 +ZWEL0001I component zss started
11.21.19 S0542560 +ZWE_zowe_sysMessages_3=ZWES1601I
11.21.19 S0542560 +ZWE_zowe_sysMessages_4=ZWEL0008I
11.21.19 S0542560 +ZWE_zowe_sysMessages_5=ZWEL0022I
11.21.19 S0542560 +ZWE_zowe_sysMessages_6=ZWEL0001I
11.21.19 S0542560 +ZWE_zowe_sysMessages_7=ZWEL0002I
11.21.19 S0542560 +ZWE_zowe_sysMessages_8=ZWEAM000I
11.21.19 S0542560 +ZWE_zowe_sysMessages_9=ZWED0031I
11.21.19 S0542560 +ZWE_zowe_sysMessages_10=ZWES1013I
11.21.19 S0542560 +ZWE_zowe_sysMessages=ZWEL0021I,ZWEL0018I,ZWEL0006I,ZWES1601I,ZWEL0008I,ZWEL0022I,ZWEL0001I,ZWEL0002I,ZWEAM000I,
ZWED0031I,ZWES1
11.21.19 S0542560 +ZWE_zowe_sysMessages_0=ZWEL0021I
11.21.19 S0542560 +ZWE_zowe_sysMessages_1=ZWEL0018I
11.21.19 S0542560 +ZWE_zowe_sysMessages_2=ZWEL0006I
11.21.20 S0542560 +ZWES1013I ZSS Server has started. Version '2.12.0+20231016' 31-bit
11.21.21 S0542560 + "ZWEL0021I",
11.21.21 S0542560 + "ZWEL0018I",
11.21.21 S0542560 + "ZWEL0006I",
11.21.21 S0542560 + "ZWES1601I",
11.21.21 S0542560 + "ZWEL0008I",
11.21.21 S0542560 + "ZWEL0022I",
11.21.21 S0542560 + "ZWEL0001I",
11.21.21 S0542560 + "ZWEL0002I",
11.21.21 S0542560 + "ZWEAM000I",
11.21.21 S0542560 + "ZWED0031I",
11.21.21 S0542560 + "ZWES1013I"
There was a problem hiding this comment.
Right, thanks @1000TurquoisePogs going to make a ticket now to remind us to get back to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title makes sense