Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SAF resource provider doc #4042

Open
wants to merge 5 commits into
base: docs-staging
Choose a base branch
from

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Dec 20, 2024

Describe your pull request here:

List the file(s) included in this PR:

After creating the PR, follow the instructions in the comments.

Signed-off-by: Andrea Tabone <[email protected]>
@taban03 taban03 requested a review from janan07 December 20, 2024 08:43
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

⚠️ Looks like something is wrong with the PR description. Remember to add a description and the file(s) included in this PR.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

🔍 The review label is missing. Add a review: label so we can determine who needs to approve this PR.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

📌 The subject area label is missing. Add an area: label so we know what your content is about.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Copy link

💾 The release label is missing. Add a release: label so your content is published with the correct major Zowe release.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

Comment on lines 13 to 19
- **`native`**
The Native JZOS classes from Java are used to determine SAF resource access. This is the default provider.

The Native JZOS classes from Java are used to determine SAF resource access. This is the default provider.

**Note:** This provider cannot be used off-platform.

- **`endpoint`**
The Endpoint provider relies on APIs such as a REST endpoint call (ZSS or similar one). This option is disabled by default. In Zowe, ZSS provides the API to check for SAF resource authorization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it can be considered a breaking change (for anyone relying on the default being endpoint)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some note or clarification that this is the default from 3.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in theory the default was still native, as long as they didn't set endpoint.enabled to true.

Comment on lines 29 to 30
If no value is assigned to Use the parameter value to
strictly define a provider. If verification is disabled, select the `endpoint` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be rewritten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed that, thanks. I'm just not totally sure about If verification is disabled, select the endpoint option. meaning


To configure the `endpoint` provider, add the following additional property:
`components.gateway.apiml.security.authorization.endpoint.enabled: true`
* **Native**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the sections should follow this same sequence (Native, Endpoint, Dummy). Can the sections be reordered in this same sequence?

- `components.gateway.apiml.security.authorization.endpoint.url: <endpoint_url>`

When using ZSS, the default value the property
`components.gateway.apiml.security.authorization.endpoint.url` is `https://${ZWE_haInstance_hostname}:${GATEWAY_PORT}/zss/api/v1/saf-auth`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the variables that require customization in the following format:

  • ZWE_haInstance_hostname
    Specifies....

  • GATEWAY_PORT
    Specifies ...

Copy link

github-actions bot commented Dec 27, 2024

@github-actions github-actions bot temporarily deployed to pull request December 27, 2024 10:26 Inactive
- Classes and resources are mapped into a map, user IDs into a list.
- The load method does not support formatting with dots, such as shown in the following example:
- Classes and resources are mapped into a map with user IDs contained in a list.
- The load method does not support formatting with periods `.`, such as shown in the following example:
**Example:** `{CLASS}.{RESOURCE}`
Ensure that each element is separated.
- The field `safAccess` is not required to define an empty file without a definition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a conclusion statement that describes the end result of completing this procedure? Thanks

Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request December 27, 2024 10:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants