Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommendations based on testing for PSWI deployment #4023

Merged
merged 19 commits into from
Dec 4, 2024
Merged

Add recommendations based on testing for PSWI deployment #4023

merged 19 commits into from
Dec 4, 2024

Conversation

pablocarle
Copy link
Contributor

Add recommendations based on testing for PSWI deployment

List the file(s) included in this PR:

  • docs/user-guide/install-zowe-pswi-acquire.md
  • docs/user-guide/install-zowe-pswi-deployment.md
  • docs/user-guide/install-zowe-pswi.md
  • versioned_docs/version-v2.18.x/user-guide/install-zowe-pswi-acquire.md
  • versioned_docs/version-v2.18.x/user-guide/install-zowe-pswi-deployment.md
  • versioned_docs/version-v2.18.x/user-guide/install-zowe-pswi.md

Pablo Hernán Carle added 2 commits November 27, 2024 10:02
markdown linter
8ad632d 
Signed-off-by: Pablo Hernán Carle <[email protected]>
add recommendations for installation
7e2fba3 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@github-actions GitHub Actions
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

🚀 Deployed on https://675060658cf2b40e9021c5e2--zowe-docs-master.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 13:22 Inactive
@pablocarle pablocarle added area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content review: doc Needs review by Doc Squad member review: sme Needs review by an SME labels Nov 27, 2024
@janan07
language/grammar improvements
49e5ae4 
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 16:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 16:44 Inactive
Pablo Hernán Carle added 2 commits November 28, 2024 09:50
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 08:57 Inactive
address review
b119d82 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 09:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 13:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 11:29 Inactive
@janan07
formatting fixes
561f44a 
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 13:17 Inactive
janan07
janan07 reviewed Dec 3, 2024
View reviewed changes
docs/user-guide/install-zowe-pswi-deployment.md Outdated
Delete this name manually.

:::note
Note that the deployment job is unable to clean this data set name once this is recreated because the random id will change.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "this" in the sentence "once this is recreated..."? Please replace "this" with the specific thing that is being recreated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this" refers to the dataset a few lines above - .SWDEPL.<random_id>.ZFS
The note should clarify why the manual cleanup is needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rewritten note accurate:
Note that the deployment job is unable to clean this data set name once the data set is recreated because the value for random_id will change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this note also be included in v2.18? Currently it is not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better. I synced the changes with v2.18

@janan07
minor fixes
0180c9b 
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 15:32 Inactive
@janan07
make v3 and v2.18 intro consistent
91a83d9 
Signed-off-by: Andrew Jandacek <[email protected]>
janan07
janan07 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and edited by doc squad

@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 15:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 4, 2024 09:48 Inactive
@janan07
change note
8698675 
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request December 4, 2024 13:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 4, 2024 13:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 4, 2024 13:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 4, 2024 14:02 Inactive
@janan07 janan07 merged commit 2ebe319 into master Dec 4, 2024
3 of 4 checks passed
@janan07 janan07 deleted the reboot/fix/pswi-fix branch December 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janan07 janan07 janan07 approved these changes

@richard-salac richard-salac richard-salac approved these changes

Assignees
No one assigned
Labels
area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content review: doc Needs review by Doc Squad member review: sme Needs review by an SME
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablocarle @richard-salac @janan07