Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional behaviour corrections #186

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

chinmdas
Copy link
Contributor

@chinmdas chinmdas commented Dec 23, 2024

What It Does
As part of this PR, we have fixed following scenarios:

  1. Manage Profile option missing in CICS Explorer when we right click on available CICS Profile.
  2. If a config file is available, CICS Explorer currently shows Edit Team Configuration File option only, where as ZE shows Create a New Team Configuration File option as well.
  3. In CICS Explorer, currently we do not have option to create Project level Team Configuration file, i.e Project: in the current working directory.

How to Test
Tested against Zowe Explorer

Review Checklist
I certify that I have:

Additional Comments

packages/vsce/src/commands/manageSessionCommand.ts Dismissed Show dismissed Hide dismissed
packages/vsce/src/trees/CICSTree.ts Fixed Show fixed Hide fixed
packages/vsce/src/trees/CICSTree.ts Fixed Show fixed Hide fixed
Signed-off-by: Chinmay Das <[email protected]>
Signed-off-by: Chinmay Das <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (3786293) to head (40bd20a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          75       75           
  Lines         770      770           
  Branches       42       43    +1     
=======================================
  Hits          722      722           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinmdas
Copy link
Contributor Author

This PR fixes #179

@chinmdas
Copy link
Contributor Author

chinmdas commented Dec 23, 2024

I have recorded screen to show you guys the functional testing of CICS Extension.
I have started covering the scenarios with following chronological order:

  1. Started with NO configuration file (Local and Global both)
  2. Creation success + Edit Success
  3. Edited the config file to remove all the profile. Blank profile.
  4. No errors --> Creation success + Edit Success
  5. Replaced configuration file with proper connection details
  6. created 2 connection. 1 from Global config file + 1 from Local config file.
  7. Right click -> Manage Profile options available
  8. on click of Manage Profile -> Update / Hide / Delete
  9. Hide -> works
  10. Update / Delete -> open global config file when global config is edited.
  11. Update / Delete -> open local config file when local config is edited.
Screen.Recording.2024-12-24.at.10.01.10.AM.mov

@chinmdas chinmdas linked an issue Dec 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Functional behaviour correction in CICS explorer to match ZE
2 participants