-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed v1 changes from vsce package #185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 93.76% 93.76%
=======================================
Files 75 75
Lines 770 770
Branches 43 43
=======================================
Hits 722 722
Misses 48 48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me..!!!
Signed-off-by: Rushabh Sojitra <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
0440542
to
0e899ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks @almightyrush! Will re-approve if needed once conflicts are resolved.
I noticed that the quick pick for adding a CICS profile has a strange placeholder. Minor cosmetic bug so not requesting changes here.
@traeok - when do you see that placeholder? i don't see it 🤔 |
This is what shows when clicking on the "+" icon (Create a CICS Profile) in the CICS tree view: Looks like it's coming from line 107 of |
Signed-off-by: Rushabh Sojitra <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
@traeok - Resolved conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 🙏
Thanks for keeping the discussion here in the PR! 🙏
Oh - the icon? I thought you meant |
What It Does
Removed the V1 changes which are no longer used.
How to Test
Review Checklist
I certify that I have:
Additional Comments