Fanpage.it #3241
Open
Fanpage.it #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translator for Italian newspaper Fanpage.it. Supports articles and search pages
AbeJellinek
requested changes
May 10, 2024
|
|
||
| function detectWeb(doc, url) { | ||
| if (getSearchResults(doc, true)) return 'multiple' | ||
| return 'newspaperArticle'; |
There was a problem hiding this comment.
Check that it is actually an article!
Comment on lines
+79
to
+80
| let section = doc.querySelector('meta[property="og:site_name"]')?.content; | ||
| let date = doc.querySelector('time.fp_info__date-updated')?.dateTime; |
There was a problem hiding this comment.
Suggested change
| let section = doc.querySelector('meta[property="og:site_name"]')?.content; | |
| let date = doc.querySelector('time.fp_info__date-updated')?.dateTime; | |
| let section = attr(doc, 'meta[property="og:site_name"]', 'content'); | |
| let date = attr('time.fp_info__date-updated', 'datetime'); |
| let date = doc.querySelector('time.fp_info__date-updated')?.dateTime; | ||
| let author = text(doc, '.fp_author__name a[data-anact="autore"]'); | ||
|
|
||
| let linkedData = document.querySelector('script[type="application/ld+json"]')?.textContent; |
There was a problem hiding this comment.
Suggested change
| let linkedData = document.querySelector('script[type="application/ld+json"]')?.textContent; | |
| let linkedData = text('script[type="application/ld+json"]'); |
Comment on lines
+95
to
+96
| if (section) item.section = ZU.trim(section); | ||
| if (date) item.date = ZU.trim(date); |
There was a problem hiding this comment.
Suggested change
| if (section) item.section = ZU.trim(section); | |
| if (date) item.date = ZU.trim(date); | |
| if (section) item.section = section.trim(); | |
| if (date) item.date = date.trim(); |
No need for ZU.trim() in modern browsers.
| if (date) item.date = ZU.trim(date); | ||
| if (author) { | ||
| item.creators.push({ | ||
| lastName: ZU.trim(author), |
There was a problem hiding this comment.
Often not institutional creators, right? So we can use ZU.cleanAuthor() and not set fieldMode: 1.
|
Sorry, didn't actually submit my review comments here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translator for Italian newspaper Fanpage.it. Supports articles and search pages