Fix: Cloning objects with children with missing Converters could resu…

…lt in an unhandled exception.

CHANGELOG.md

@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 * Reading recorder files with objects with a missing Converter could result in an unhandled exception.
+* Cloning objects with children with missing Converters could result in an unhandled exception.
 
 
 ## [v0.8.0]

src/Recorder.cs

@@ -550,8 +550,16 @@ internal override void Record<T>(ref T value, string label, Parameters parameter
 
             seen?.Add(label);
 
-            // Explicit cast here because we want an error if we have the wrong type!
-            value = (T)recorded.ParseElement(typeof(T), value, readerGlobals, parameters.CreateSettings());
+            // Avoid an explicit cast because that can cause null reference errors
+            var result = recorded.ParseElement(typeof(T), value, readerGlobals, parameters.CreateSettings());
+            if (result != null)
+            {
+                value = (T)result;
+            }
+            else
+            {
+                value = default;
+            }
         }
 
         public override void Ignore(string label)

test/unit/Misc.cs

@@ -23,6 +23,16 @@ public void Record(Dec.Recorder recorder)
             }
         }
 
+        struct TestStructMember : Dec.IRecordable
+        {
+            public TestStruct value;
+
+            public void Record(Dec.Recorder recorder)
+            {
+                recorder.Record(ref value, nameof(value));
+            }
+        }
+
         [Test]
         public void UnavailableStructRecorderNormal()
         {
@@ -52,5 +62,13 @@ public void UnavailableStructRecorderAsThis()
 
             ExpectErrors(() => Dec.Recorder.Read<TestStructAsThis>(recorded));
         }
+
+        [Test]
+        public void UnavailableStructRecorderClone()
+        {
+            var initial = new TestStructMember();
+
+            ExpectErrors(() => Dec.Recorder.Clone(initial));
+        }
     }
 }