Add dropdowns for the adapter and dataset names #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
requested changes
May 31, 2022
| @@ -8,17 +8,26 @@ | |||
|
|
|||
|
|
|||
| class ImageryRequest(models.Model): | |||
| adapter_name = models.CharField(max_length=64, null=False) | |||
| dataset_name = models.CharField(max_length=64, null=False) | |||
| adapter_choices = ( | |||
There was a problem hiding this comment.
I think SOMETHING_choices should be an array of tuples.
Suggested change
| adapter_choices = ( | |
| adapter_choices = [ | |
| ('US Geological Survey', 'usgs') | |
| ] |
| adapter_choices = ( | ||
| ('US Geological Survey', 'usgs') | ||
| ) | ||
| dataset_choices = ( |
There was a problem hiding this comment.
Suggested change
| dataset_choices = ( | |
| dataset_choices = [ | |
| ("landsat_8_c1","LANDSAT_8_C1"), | |
| ("landsat_tm_c1","LANDSAT_TM_C1"), | |
| ("landsat_etm_c1","LANDSAT_ETM_C1") | |
| ] |
This comment was marked as resolved.
This comment was marked as resolved.
|
oh! i know why tests are failing. these can easily be fixed by doing a find and replace all and change any reference of we should also create a new migration NOTE TO SELF: upon deployment to prod double check that db has updated with new table name change on imagery_request (if not, run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, in order to make an Imagery Request, researchers needed to type in the name of the adapter and dataset they wanted to use. But the thing is, only a finite set of values work for these fields. So here are some dropdowns for those fields instead!