Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check to prevent soft deleted subject added to subject set #4355

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Tooyosi
Copy link
Contributor

@Tooyosi Tooyosi commented Jul 4, 2024

Describe your change here.
Added a check to make sure only active subjects are added to subject_sets.
Solves for this issue

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 linked an issue Jul 8, 2024 that may be closed by this pull request
@Tooyosi Tooyosi merged commit 115e6de into master Jul 9, 2024
8 checks passed
@Tooyosi Tooyosi deleted the prevent-soft-deleted-subject-add-to-subject-set branch July 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Able to add soft-deleted subjects to subject set
2 participants