Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & update resend confirmation view #4277

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix & update resend confirmation view #4277

merged 1 commit into from
Jan 26, 2024

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Jan 26, 2024

Old form's submit button was broken. Updated some of the partials and fixed some warnings. Got as close to the right look as I could.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@zwolf zwolf merged commit 93f40f5 into master Jan 26, 2024
8 checks passed
@zwolf zwolf deleted the resend-confirmation branch January 26, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant